Importer will get slow and memory issue if large number of products imported

[gomcodoctor]

product importer is prone to memory issue if entities are not cleared regularly.
for CLASSNAMES - we can add a method call on service to add list of all classes to clear.

Suggestion and feedback appreciated

$this->objectManager->flush();

should be replaced to

$this->objectManager->flush();

            foreach(CLASSNAMES  as CLASSNAME) 
                $this->objectManager->clear(CLASSNAME)

public function importData(int $i, array $row): bool
    {
        try {
            $this->resourceProcessor->process($row);
            $this->result->success($i);

            ++$this->batchCount;
            if ($this->batchSize && $this->batchCount === $this->batchSize) {
                $this->objectManager->flush();
                $this->batchCount = 0;
            }
        } catch (ItemIncompleteException $e) {
            $this->result->setMessage($e->getMessage());
            $this->result->getLogger()->critical($e->getMessage());
            if ($this->failOnIncomplete) {
                $this->result->failed($i);
                if ($this->stopOnFailure) {
                    return true;
                }
            } else {
                $this->result->skipped($i);
            }
        } catch (ImporterException $e) {
            $this->result->failed($i);
            $this->result->setMessage($e->getMessage());
            $this->result->getLogger()->critical($e->getMessage());
            if ($this->stopOnFailure) {
                return true;
            }
        }

        return false;
    }

[oallain]

Hi @gomcodoctor

Yes, we can do that 😄
Do you want to propose PR ?