Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Undefined property: FOS\ElasticaBundle\Client::$logger #304

Merged
merged 1 commit into from May 30, 2013
Merged

Conversation

ceednee
Copy link
Contributor

@ceednee ceednee commented May 30, 2013

No description provided.

@lucasmilin
Copy link

Hi!

Can you change the reference code in Packagist because project installation with Composer is broken.

Thanks.

@jmikola
Copy link
Member

jmikola commented May 30, 2013

See: ruflin/Elastica@231f8ff

Thanks for the PR.

jmikola added a commit that referenced this pull request May 30, 2013
Fixes Undefined property: FOS\ElasticaBundle\Client::$logger
@jmikola jmikola merged commit 00fde68 into FriendsOfSymfony:master May 30, 2013
@sheeep
Copy link

sheeep commented May 31, 2013

This change has not fixed the actual issue for me. I'm still observing fatal erros after updating composer.

Fatal error: Interface 'Psr\Log\LoggerInterface' not found in [...]

Psr\Log is a dependency of a dependency of this bundle. And as I remember, composer is not able to resolve dependencies recursively. I was able to get my installation back to work by simply adding the two deps of ruflin/Elastica to my composer file.

"psr/log": "~1.0",
"munkie/elasticsearch-thrift-php": "1.4.*"

Is there any other way to resolve this? (as I clearly see that this is a dirty workaround.)

@jmikola
Copy link
Member

jmikola commented May 31, 2013

I missed the other PR where the PSR Logger interface was being explicitly included. We should definitely have that as a dependency.

Composer certainly resolves dependencies of dependencies, but my guess is that you had a lock file with an older version of Elastica that happened to match the same dev version we're requiring here.

@jmikola
Copy link
Member

jmikola commented May 31, 2013

Ah, Elastica lists it as a dev requirement and suggested package (see: here). That will do it. I'll add it as an explicit dep now.

@lsmith77
Copy link
Member

+1

jmikola added a commit that referenced this pull request May 31, 2013
tumbochka pushed a commit to formapro-forks/FOSElasticaBundle that referenced this pull request Jul 17, 2014
…dex-empty-cvs

[sitemap] do not index empty cvs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants