Merge pull request #501 from FriendsOfSymfony/github-phpstan

phpstan static analysis with github workflow

.github/workflows/.editorconfig

@@ -0,0 +1,2 @@
+[*.yml]
+indent_size = 2

.github/workflows/static.yml

@@ -0,0 +1,46 @@
+name: Static analysis
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+
+jobs:
+  phpstan:
+    name: PHPStan src
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Pull in optional dependencies
+        run: |
+          composer require --no-update symfony/http-kernel symfony/event-dispatcher symfony/process phpunit/phpunit psr/log toflar/psr6-symfony-http-cache-store
+          composer update --no-dev --no-progress
+
+      - name: PHPStan
+        uses: docker://oskarstark/phpstan-ga
+        with:
+          args: analyze --no-progress
+
+  phpstan-tests:
+    name: PHPStan tests
+    runs-on: ubuntu-latest
+    env:
+      REQUIRE_DEV: "true"
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Pull in optional dependencies
+        run: |
+          composer require --no-update phpunit/phpunit toflar/psr6-symfony-http-cache-store
+          composer update --no-progress
+
+      - name: PHPStan
+        uses: docker://oskarstark/phpstan-ga
+        with:
+          args: analyze --no-progress -c phpstan.tests.neon.dist

phpstan.neon.dist

@@ -0,0 +1,11 @@
+parameters:
+    level: 1
+    paths:
+        - src
+    excludePaths:
+        analyseAndScan:
+            # contains code to support legacy phpunit versions
+            # TODO: clean up the code in this namespace and support fewer phpunit versions
+            - src/Test/*
+            # contains BC code to support Symfony 3.4 that would not work with never versions
+            - src/BaseEvent.php

phpstan.tests.neon.dist

@@ -0,0 +1,4 @@
+parameters:
+    level: 1
+    paths:
+        - tests

src/ProxyClient/Fastly.php

@@ -15,7 +15,6 @@
 use FOS\HttpCache\ProxyClient\Invalidation\PurgeCapable;
 use FOS\HttpCache\ProxyClient\Invalidation\RefreshCapable;
 use FOS\HttpCache\ProxyClient\Invalidation\TagCapable;
-use Symfony\Component\HttpFoundation\Request;
 
 /**
  * Fastly HTTP cache invalidator.
@@ -68,7 +67,7 @@ public function invalidateTags(array $tags)
         // Split tag invalidations across several requests within Fastly's tag batch invalidations limits.
         foreach (\array_chunk($tags, self::TAG_BATCH_PURGE_LIMIT) as $tagChunk) {
             $this->queueRequest(
-                Request::METHOD_POST,
+                'POST',
                 $url,
                 $headers,
                 false,
@@ -116,7 +115,7 @@ public function refresh($url, array $headers = [])
 
         // Secondly make sure refresh is triggered with a HEAD request
         $this->queueRequest(
-            Request::METHOD_HEAD,
+            'HEAD',
             $url,
             $headers,
             false
@@ -137,7 +136,7 @@ public function refresh($url, array $headers = [])
     public function clear()
     {
         $this->queueRequest(
-            Request::METHOD_POST,
+            'POST',
             sprintf(self::API_ENDPOINT.'/service/%s/purge_all', $this->options['service_identifier']),
             ['Accept' => 'application/json'],
             false

src/Test/Proxy/AbstractProxy.php

@@ -12,7 +12,6 @@
 namespace FOS\HttpCache\Test\Proxy;
 
 use Symfony\Component\Process\Process;
-use Symfony\Component\Process\ProcessBuilder;
 
 abstract class AbstractProxy implements ProxyInterface
 {
@@ -100,16 +99,7 @@ protected function wait($timeout, $callback)
      */
     protected function runCommand($command, array $arguments)
     {
-        if (method_exists(Process::class, 'setStdin')) {
-            // Symfony 2, process can not handle an array as command. Use the meanwhile deprecated ProcessBuilder
-            $builder = new ProcessBuilder($arguments);
-            $builder->setPrefix($command);
-
-            $process = $builder->getProcess();
-        } else {
-            $process = new Process(array_merge([$command], $arguments));
-        }
-
+        $process = new Process(array_merge([$command], $arguments));
         $process->run();
 
         if (!$process->isSuccessful()) {