Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PHPUnit assertions smarter #112

Closed
ddeboer opened this issue Aug 6, 2014 · 1 comment
Closed

Make PHPUnit assertions smarter #112

ddeboer opened this issue Aug 6, 2014 · 1 comment

Comments

@ddeboer
Copy link
Member

ddeboer commented Aug 6, 2014

Let’s throw an exception if the cache hit/miss header was not found in the response, with a message like: ‘please enable cache debugging for the assertions to work’.
@dbu
Copy link
Contributor

dbu commented Aug 6, 2014

oh, indeed. +1

@ddeboer ddeboer closed this as completed in 9019dad Aug 6, 2014
dbu added a commit that referenced this issue Aug 6, 2014
@dbu
Merge pull request #114 from FriendsOfSymfony/fix-112
4d6ec3b 
Throw exception if cache hit/miss header is missing (fix #112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbu @ddeboer