-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document symfony test case #205
Conversation
however, i just bumped the alias in composer.json to 1.4 looking at 1.3.2...master we should have done that around "adding client for the symfony built-in reverse proxy HttpCache - 40b24bd" . we could do a 1.3 branch from the commit before that, but not sure if we need it. even. we can always do one from 1.3.2 if needed. the changes since 1.3.2 before the symfony HttpCache where all to the doc, not to the code i think. |
As we agreed to keep our releasing strategy as simple as possible, just moving on towards 1.4 is fine with me. |
@@ -112,7 +112,7 @@ Constant Getter Default | |||
Must match `proxy_cache_path` directive in | |||
your configuration file. | |||
``WEB_SERVER_HOSTNAME`` ``getHostName()`` hostname your application can be reached at | |||
======================= ========================= ================================================ ========================================== | |||
======================= ========================= ================================================ =========================================== | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, the ===
s are hard to read. I’m assuming you got them right. 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looked right in my editor. yeah, table and markup formats are not friends...
f3f6285
to
1e3138c
Compare
test. The test cases only handle running the caching proxy. With PHP 5.4 or | ||
newer, the easiest is to use the PHP built in web server. See the | ||
``WebServerListener`` class in ``tests/Functional`` and how it is registered in | ||
``phpunit.xml.dist``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually we could make this easily reusable. but moving it might break things for people who already used it, so created a v2 task: #206
should be good now i hope. |
i would prefer to not just yet tag a stable release (we could do an RC-1 if you want).
i want to have a look at FriendsOfSymfony/FOSHttpCacheBundle#209 - maybe we find issues that will be easier to fix now than after a release.