[cache tagging] http_resp_hdr_len check #273
Conversation
| */ | ||
| $tagsize = max(array_map('mb_strlen', $escapedTags)); | ||
| $elems = floor($this->headerLength / ($tagsize - 1)) ? : 1; | ||
|
|
There was a problem hiding this comment.
we could do } else { $elems = count($escapedTags); }
and then have the foreach outside the if/else, to avoid the 3 redundant lines of code in the else below.
that should not cost much extra processing power, and avoids code duplication. there would be only one chunk so the foreach would only be executed once.
There was a problem hiding this comment.
what do you think about this idea?
There was a problem hiding this comment.
yes, makes sense!
wickedOne
force-pushed
the
header-length
branch
from
08beb81
to
0628c11
Compare
dbu
changed the title
|
looks good, thanks a lot! can you please add a note in the CHANGELOG.md file? |
wickedOne
force-pushed
the
header-length
branch
from
0628c11
to
1ea0cf7
Compare
|
done |
|
you think those travis errors related to this pull request? |
[cache tagging] http_resp_hdr_len check
|
thanks! the test failure looks unrelated indeed. seems our way of starting servers has become unreliable somehow. do you want to have a go at porting things to master? creating a branch from 1.4 and do a PR to master from that branch. |
|
i released https://github.com/FriendsOfSymfony/FOSHttpCache/releases/tag/1.4.2 with this fix. |
|
ok, will have a go at merging 1.4 into master |
fixes #269
notes:
getTagsHeaderandsetTagsHeaderare marked as depricated in theCacheInvalidatori didn't provide seperate functions for theheaderLength.http_resp_hdr_lendefaults to 8000 bytes, i defaulted theheaderLengthto 7500 bytes to be on the safe side