test with php 7.4 #472
Merged
test with php 7.4 #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dbu
commented
Nov 28, 2019
•
dbu
commented
- Restart when php 7.4 is available on travis-ci
dbu
force-pushed
the
php-7.4
branch
6 times, most recently
from
26175c8
to
7111817
Compare
|
Any reason you're not using the Symfony PHPUnit bridge which already does all the compatibility stuff for you? 🙈 |
|
what compatibility does it do? does it backport functionality like the assertStringContainsString? is just having the bridge available enough, or will i need to do something specific? i should probably use it anyways, because some things in src/ are about phpunit < 7 while others are exclusively for 7 and not 8. and right now we only test 5.7 and 8. providing phpunit integration for others makes me want to also run a test with phpunit 6 and 7. |
|
Yeah exactly. My gut feeling tells me that it might help you big time in this PR but needs to be verified. Just chipping in an idea here :) |
dbu
force-pushed
the
php-7.4
branch
2 times, most recently
from
2a67d0d
to
6b11245
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.