Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled match case #629

Closed
mankej opened this issue May 4, 2024 · 3 comments · Fixed by #630
Closed

Unhandled match case #629

mankej opened this issue May 4, 2024 · 3 comments · Fixed by #630

Comments

@mankej
Copy link

mankej commented May 4, 2024


If there are other attributes, this listener is raising the error 'Unhandled match case'. IMHO there needs to be a default case :)
I was forced to downgrade package :)

@dbu
Copy link
Contributor

dbu commented May 5, 2024

oh, i think you are right. thanks for reporting this regression. was not aware that match works like this - though it makes sense to avoid accidentally overlooking cases. adding the default case in #630 - can you test that branch in your project and report if that fixes the issue? if it does i will merge and release.

@RichardJong
Copy link

Same here, #630 fixes the issue 👍

@dbu dbu closed this as completed in #630 May 7, 2024
@dbu
Copy link
Contributor

dbu commented May 7, 2024

thanks for reporting. i just released the fixed version: https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/releases/tag/3.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants