prepare release 1.0.0 #128
Conversation
| @@ -22,7 +22,7 @@ | |||
| ], | |||
| "require": { | |||
| "php": ">=5.3.3", | |||
| "friendsofsymfony/http-cache": "~1.0.0-alpha3@dev", | |||
| "friendsofsymfony/http-cache": "1.*", | |||
There was a problem hiding this comment.
this is fine if we stick to the strict semver plan.
There was a problem hiding this comment.
Yep. If the bundle starts to depends on features introduced in later lib versions (e.g., 1.3) we should replace this accordingly (~1.3).
There was a problem hiding this comment.
I would use ~1.0 (which is equivalent to 1.*). It advocates the best practice of using the ~ operator ofr libraries following semver, and it makes things easier when bumping the requirement (if you ask a contributor to bump the requirement to 1.1 in a PR using a new feature, he will probably change the constraint to 1.1.* if he does not know composer well, when using this 1.* range)
|
thanks david. what is still blocking us from going stable? #134 should be resolved, but looks like ending as a documentation issue for now. on the library, i don't see any blockers. shall i tag 1.0.0 of the library and we see if this PR then properly builds? and maybe wait another day or two if we get more feedback, then release the bundle? |
|
While I don’t see any blockers, I don’t mind just waiting for a couple days to see if any more feedback requiring immediate bugfixes comes in. What about waiting till Monday and then release both lib and bundle? |
|
sounds good yes! and feedback is coming in indeed, so its worth to give |
|
i released FOSHttpCache now. this PR is green, i now squashed the commits. lets release? |
|
👍 |
|
🎉 |
|
🍰 🍺 |
fix #91
this actually is ready but should only be merged right before release.