also provide request itself in expressions #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Do we need extend our tests for this? |
|
hm, not so much that can go wrong, but we should nonetheless. added a note to #120 for now. |
Merged
|
are you ok to merge this without the test and do that later? |
ddeboer
added a commit
that referenced
this pull request
Aug 19, 2014
also provide request itself in expressions
|
Yep! |
| $values = $request->attributes->all(); | ||
| // if there is an attribute called "request", it needs to be accessed through the request. | ||
| $values['request'] = $request; | ||
| $expressionLanguage = $this->getExpressionLanguage(); |
There was a problem hiding this comment.
this means that you now require the ExpressionLanguage to be available even when no route is using it.
given the private getter caches it anyway, it does not have much value to use a local variable
There was a problem hiding this comment.
ouch, that was not intended!
will fix that after lunch
There was a problem hiding this comment.
Omg @stof, you’re everywhere, thanks for the catch! 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up of #119