allow to configure custom proxy client #208
Conversation
| to work. | ||
|
|
||
| The proxy client is also directly available as a service | ||
| (``fos_http_cache.proxy_client.default`` and .varnish or .nginx) that you can use |
There was a problem hiding this comment.
Add backticks around varnish and nginx or perhaps spell them fully for clarity.
|
fixed the doc. do you agree with naming the option "custom_proxy_client"? i first had proxy_client but while documenting, i realized that this becomes really confusing with a proxy_client section and then a proxy_client field for a service name. and when the proxy_client section is configured, you specify in there which the default client is, it would be wrong to specify the nginx / varnish client service name in the custom_proxy_client field. |
|
@ddeboer ping |
| @@ -10,6 +11,7 @@ by default if a :doc:`Proxy Client <proxy-client>` is configured. | |||
| fos_http_cache: | |||
| cache_manager: | |||
| enabled: true | |||
| custom_proxy_client: ~ | |||
There was a problem hiding this comment.
What does this mean? Isn’t a service name a requirement for a custom client?
There was a problem hiding this comment.
the way the configuration works is that this value defaults to null meaning there is no custom client service. if you configure this to a non-null value, that service will be used instead of the default one.
we can't hardcode the client here, because that depends on whether you configure the symfony or varnish or nginx client.
Yes. |
allow to configure custom proxy client
fix #186
This does not handle the test case section, but then i don't think we need to care about that. The test case would need to know about the caching proxy implementation anyways.