Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency on a non-existent service "security.context" #261

Merged
merged 1 commit into from
Dec 9, 2015

Conversation

Tobion
Copy link
Member

@Tobion Tobion commented Dec 9, 2015

The security part is optional in the role provider class, which is why security.token_storage is also defined with on-invalid=ignore.
As we have security disabled in dev env, neither security.token_storage nor security.context exists, but it still tries to replace the dependency and loses on-invalid=ignore. Then it was complaining, that the service is missing.

The security part is optional in the role provider class, which is why `security.token_storage` is also defined with `on-invalid=ignore`.
As we have security disabled in dev env, neither security.token_storage nor security.context exists, but it still tries to replace the dependency and loses on-invalid=ignore. Then it was complaining, that the service is missing.
@Tobion
Copy link
Member Author

Tobion commented Dec 9, 2015

@ddeboer @dbu would be nice to merge this and it prevents us to upgrade to symfony 2.8

dbu added a commit that referenced this pull request Dec 9, 2015
Fix dependency on a non-existent service "security.context"
@dbu dbu merged commit b75a42a into FriendsOfSymfony:1.3 Dec 9, 2015
@dbu
Copy link
Contributor

dbu commented Dec 9, 2015

thanks. the build fails for some versions, but this also happens with the main 1.3 branch and seems not related. i think we fixed that one on master but not in 1.3

i will have a look and try to fix that before tagging a patch release. for now you should be able to use 1.3.*@dev

@Tobion Tobion deleted the patch-1 branch December 9, 2015 17:48
@Tobion
Copy link
Member Author

Tobion commented Dec 9, 2015

The versioning for this bundle is messed up.

@Tobion
Copy link
Member Author

Tobion commented Dec 9, 2015

So please backport #239 to branch 1.3 (and/or change the branch alias). Or if master is not supposed to be version 2.x already, then we dont need the 1.3 branch and ony change the branch-alias.

@dbu
Copy link
Contributor

dbu commented Dec 9, 2015 via email

@dbu
Copy link
Contributor

dbu commented Dec 9, 2015 via email

@dbu
Copy link
Contributor

dbu commented Dec 9, 2015 via email

@Tobion
Copy link
Member Author

Tobion commented Dec 9, 2015

Looks good, only a memory problem on PHP 5.3

@ddeboer
Copy link
Member

ddeboer commented Dec 9, 2015

Thanks @Tobion for pointing out our mistake. Just tagged a fixed 1.3.5 version. I considered it more important to get the update out as soon as possible than to first fix the 5.3 memory problem on Travis.

@Tobion
Copy link
Member Author

Tobion commented Dec 9, 2015

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants