-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dependency on a non-existent service "security.context" #261
Conversation
The security part is optional in the role provider class, which is why `security.token_storage` is also defined with `on-invalid=ignore`. As we have security disabled in dev env, neither security.token_storage nor security.context exists, but it still tries to replace the dependency and loses on-invalid=ignore. Then it was complaining, that the service is missing.
Fix dependency on a non-existent service "security.context"
thanks. the build fails for some versions, but this also happens with the main 1.3 branch and seems not related. i think we fixed that one on master but not in 1.3 i will have a look and try to fix that before tagging a patch release. for now you should be able to use |
The versioning for this bundle is messed up.
|
So please backport #239 to branch 1.3 (and/or change the branch alias). Or if master is not supposed to be version 2.x already, then we dont need the 1.3 branch and ony change the branch-alias. |
argh. master is indeed about refactorings for 2.0.
i cherry-picked the few commits (all from #239) to the 1.3 branch and if
travis is green will tag 1.3.5
|
thanks for realizing that. seems we missed the split with the 1.3 branch
in that cleanup.
|
also merged 1.3 into master to get your fix there.
|
Looks good, only a memory problem on PHP 5.3 |
Thanks @Tobion for pointing out our mistake. Just tagged a fixed 1.3.5 version. I considered it more important to get the update out as soon as possible than to first fix the 5.3 memory problem on Travis. |
Thanks |
The security part is optional in the role provider class, which is why
security.token_storage
is also defined withon-invalid=ignore
.As we have security disabled in dev env, neither security.token_storage nor security.context exists, but it still tries to replace the dependency and loses on-invalid=ignore. Then it was complaining, that the service is missing.