Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ContainerAwareTrait instead of deprecated ContainerAwareCommand #529

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Use ContainerAwareTrait instead of deprecated ContainerAwareCommand #529

merged 1 commit into from
Oct 16, 2019

Conversation

emodric
Copy link
Contributor

@emodric emodric commented Oct 10, 2019 •
edited
Loading

This gets rid of the deprecation message on Symfony 4.2.

I've copied the getContainer method from ContainerAwareCommand to the command since the intention is to remove the usage of the container anyway for v3 of the bundle.

dbu
dbu approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is the right fix until we require constructor injection of the httpcache CacheManager in the constructor in version 3 of this bundle.

@dbu dbu merged commit c84007e into FriendsOfSymfony:master Oct 16, 2019
@dbu dbu mentioned this pull request Oct 16, 2019
Closed
@dbu
Copy link
Contributor

dbu commented Oct 16, 2019

tagged 2.7.2 with this, thank you @emodric

@emodric
Copy link
Contributor Author

emodric commented Oct 16, 2019

Thanks @dbu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emodric @dbu