Fix duplicated port in absolute path #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
reviewed
Apr 14, 2020
| @@ -294,14 +294,17 @@ class Router { | |||
| }); | |||
| // Foo-bar! | |||
| url = this.context_.base_url + url; | |||
|
|
|||
| const isPortInHost = host.indexOf(':' + port) > -1 || this.getHost() && this.getHost().indexOf(':' + port) > -1; | |||
There was a problem hiding this comment.
The code could be simplified (ans the performance improved) by storing the result of host || this.getHost() in a variable, and reusing it everywhere.
Same for (isPortInHost || '' === port ? '' : ':' + port)
This is not 100% related to this PR.
There was a problem hiding this comment.
I agree, this could be optimized and I would be happy to do it, but I'm not a fan of doing refactors without the maintainer's approval. I know how this may complicate merging up patches from the lower version to current and overall maintenance.
|
I confirm that this patch fixes the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue: #379
It makes sure that the port is not duplicated.