Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer require fails with Symfony 5.0 #2043

Closed
oheins opened this issue Dec 9, 2019 · 27 comments
Closed

composer require fails with Symfony 5.0 #2043

oheins opened this issue Dec 9, 2019 · 27 comments

Comments

@oheins
Copy link

oheins commented Dec 9, 2019

$ composer require friendsofsymfony/rest-bundle:dev-master 
[...]
Executing script cache:clear [KO]
 [KO]
Script cache:clear returned with error code 1
!!  
!!  In CheckExceptionOnInvalidReferenceBehaviorPass.php line 86:
!!                                                                                 
!!    The service "routing.loader" has a dependency on a non-existent service "co  
!!    ntroller_name_converter".                                                    
!!                                                                                 
!!  
!!  
Script @auto-scripts was called via post-update-cmd

Installation failed, reverting ./composer.json to its original content.

This seems to be fixed in #2036; however, this is not merged yet.

@maxhelias
Copy link

Be patient and use a stable tag rather than dev-master

@Yozhef
Copy link

Yozhef commented Dec 12, 2019

up

@wumke
Copy link

wumke commented Dec 19, 2019

Be patient and use a stable tag rather than dev-master

Anyone has an idea when 2.7 is expected to be released as stable?

@derWebdesigner
Copy link

+1

1 similar comment
@gvanbeck
Copy link

gvanbeck commented Jan 2, 2020

+1

@Josee9988
Copy link

At least you can download it in the dev version, but when will this version be available as stable??

    "minimum-stability": "dev",

@derWebdesigner
Copy link

@Josee9988 You can't anymore if I understood the last merges correctly because the dev version is now only compatible with Symfony 4.4 and Symfony 5 should be fixed in a 3.x branch. I would love to know an ETA for this as well but currently, there is none I guess?

@Webonaute
Copy link

This is a big blocker for my team. I would love to know a schedule for this. Thank.

@derWebdesigner
Copy link

@Webonaute Same to me and I would love to help somehow with a fast solution for 3.x but I am simply lacking in knowledge.

@wumke
Copy link

wumke commented Jan 20, 2020

I agree with the fact that not being Symfony 5 compatible is a big blocker for everyone that starts using Symfony at its current version (and for those who want to update to latest version).
The 3.x branch should be created as soon as possible, with the compatibility changes of the mentioned PR included.

@xabbuh
Copy link
Member

xabbuh commented Jan 20, 2020

I talked a bit with @yceruto about this. Dropping support for Symfony 4 in version 3 of FOSRestBundle is probably not the best idea. It makes updating harder and more importantly increases the maintenance overhead as doing support for 2.x would only be possible once Symfony 4.4 reaches end of life. That being said a better solution would probably be to deprecate all features that cannot be supported with Symfony 4 and 5 in 2.x and then remove them in 3.0 while keeping support for both Symfony 4.4 and 5.0.

@xabbuh
Copy link
Member

xabbuh commented Jan 20, 2020

Additionally 2.x could then go into a maintenance-only mode meaning that it would only receive bugfixes, but new features would only be added in 3.x.

@derWebdesigner
Copy link

@xabbuh Actually that sounds like a really good idea and totally makes sense Christian, especially because 4.4 is an LTS version.

@Josee9988
Copy link

Can I use FosRestBundle with 4.4 or 5? Or not yet?

@Saracevas
Copy link

Saracevas commented Jan 23, 2020

Can I use FosRestBundle with 4.4 or 5? Or not yet?

@Josee9988 not yet, no.

@Yozhef
Copy link

Yozhef commented Jan 23, 2020

@Saracevas @Josee9988 - why not use in 4.4? For Symfony 5 not work integration but in 4.4 all good work

@Josee9988
Copy link

@Yozhef I tried to use it in 4.4 and couldn't use any functions from the AbstractFosController so I had to do it all by myself. It was the first time I used symfony and FOS so maybe I did something wrong but I don't think so.
Cheers

@Yozhef
Copy link

Yozhef commented Jan 23, 2020

@Josee9988 now I have a project in Symfony 4.4 and normal work. I very wait wen bundle start support Symfony 5 =)

@wumke
Copy link

wumke commented Jan 30, 2020

@ The Package Maintainers:
So, what is the final plan regarding to FOSRest package version numbers and Symfony version compatability?

If not decided yet, can we at least have a new 'Symfony5Compatible' branch so that people using Symfony5 can make changes, test and create pull requests?

If there is a final plan, I'd suggest to place it in the readme... that avoids a lot of 'not Symfony X compatible' issues!

@Yozhef
Copy link

Yozhef commented Jan 30, 2020

@stof @lsmith77 any news? This package really blocked migrate to Symfony 5 in Installs: 22 062 486 users.

@xabbuh
Copy link
Member

xabbuh commented Jan 31, 2020

I have just tagged the 2.7.0 release which is compatible with Symfony 4.4.

The master now serves for the development of FOSRestBundle 3.0. Its version constraints already allow Symfony 5 components. I invite you to test your application with that branch, but be prepared that features that are not compatible with Symfony 5 will error in some way.

As explained in #2043 (comment) we will need to deprecate some features in the 2.x branch for FOSRestBundle 2.8 that are not compatible with Symfony 5 and remove them in 3.0. I invite everyone to help us reach this goal.

@QuentinNanomonx
Copy link

For the ones waiting for SF5 support, you can follow the team progress through 3.0 milestone
I've tested it on my project and everything is good so far with SF5!
I don't say that it will be fine for everyone, but you might give it a try ;-)

@Yozhef
Copy link

Yozhef commented Apr 28, 2020

@stof @lsmith77 When 3.0 planned release, in my team 4 service are written in Symfony 5 and everything works fine. You might make a release, because my service with dev-master dependency, not a good idea.

@patrick-mcdougle
Copy link

I trust the maintainers to release when it's ready not when any arbitrary project is successful on master. If you're not going to contribute, just be patient and wait for the 3.0 stable release. (Thanks for your hard work maintainers, don't let the impatient pressure you to release before it's time)

That being said, seeing that the milestone for 3.0 is 100% is there anything I can do to help get this over the finish line?

@xabbuh
Copy link
Member

xabbuh commented Apr 29, 2020

Thank you for your kind words @patrick-mcdougle. The plan is to release 2.8 and 3.0 at the same time. For 2.8 I would like to merge #2109 as the last change. The patch itself looks good, but I think we need to rework the tests as they still pass when the changes to the event listener are reverted.

@jawira
Copy link

jawira commented May 29, 2020

For the really impatient people, release 3.0.0-beta3 is available.

@jawira
Copy link

jawira commented Jun 4, 2020

Well, v3.0.0 is out!

@xabbuh xabbuh closed this as completed Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests