Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Pluralization as an option. #294

Closed
stephpy opened this issue Sep 6, 2012 · 9 comments
Closed

Resource Pluralization as an option. #294

stephpy opened this issue Sep 6, 2012 · 9 comments
Milestone

Comments

@stephpy
Copy link
Contributor

stephpy commented Sep 6, 2012

Hi,

Actually, routing use pluralization automatically for resources. What do you think about an option to be able to deactivate that ? For sure, by default it'll be activated ...

It could be defined on config:

fos_rest:
   resource:
       pluralize_path: true

And even on RouteResource annotation ?

/**
*@RouteResource("User", false) 
*/
@mevers47
Copy link

+1 Can be very handy in my situation where every resource has one name, not a plural and singular one. Just one singular name, like the name for an entity.

@lsmith77
Copy link
Member

i think if at all pluralization needs to be disabled only on the resource level, since otherwise it can cause incompatibilities between Bundles expecting the option to be on or off.

@tarjei
Copy link
Contributor

tarjei commented Aug 16, 2013

@lsmith77 could you provide pointers to how this should be implemented as part of the RouteResource annotation?

@lsmith77
Copy link
Member

look at the annotation class and add another property. this will result in having another attribute to set in the annotation

@tarjei
Copy link
Contributor

tarjei commented Aug 16, 2013

Ok, I tried that. I got quite far, but my unittests fail with the error:

Doctrine\Common\Annotations\AnnotationException: [Syntax Error] Expected Value, got 'r' at position 31 in class FOS\RestBundle\Tests\Fixtures\Controller\AnnotatedNonPlurlizedArticleController.

Here's the value I tried:

/**
 *  @Rest\RouteResource("Article", false)
 */
class AnnotatedNonPlurlizedArticleController extends FosRestController

And the Annotation definition:

/**
 * RouteResource annotation class.
 * @Annotation
 * @Target("CLASS")
 */
class RouteResource
{
    /**
     * @var string required
     */
    public $resource;

    /**
     * @var boolean
     */
    public $pluralize = false;


}

@lsmith77
Copy link
Member

can you just open a PR with your work? makes reviewing easier.

@tarjei
Copy link
Contributor

tarjei commented Aug 19, 2013

I'll do that tomorrow.

@lsmith77 lsmith77 added this to the 2.0 milestone Jul 10, 2015
@GuilhemN
Copy link
Member

This issue/PR seems to be abandoned ... I will continue this work in a new PR.

@lsmith77
Copy link
Member

closed via #1096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants