Fixed deprecated _method errors #1054
Conversation
Padam87
commented
Jun 2, 2015
Padam87
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #1051 |
| License | MIT |
|
|
||
| if (isset($annoRequirements['_method'])) { |
There was a problem hiding this comment.
there is another place using _method in this file
|
|
||
| // add route to collection | ||
| $route = new Route( | ||
| $path, $defaults, $requirements, $options, $host, array(), $methods, $condition | ||
| $path, $defaults, array(), $options, $host, array(), $methods, $condition |
There was a problem hiding this comment.
this is wrong. Requirements should still be set in the route
There was a problem hiding this comment.
At this point the $requirements only contained this:
There was a problem hiding this comment.
not always. There is code setting the _format requirement a few lines above
|
Also fixed the |
|
bump |
Fixed deprecated _method errors
|
Awesome, thank you! |
| $requirements['_method'] = $this->getMethod(); | ||
| $this->setRequirements($requirements); | ||
|
|
||
| $this->setMethods((array) $this->getMethod()); |
There was a problem hiding this comment.
I guess this change is problematic, since we override the method, without checking if something was set before .. ?
There was a problem hiding this comment.
14:53 <Zerrvox> lsmith: FosRestBundle 1.7 has a BC break https://github.com/FriendsOfSymfony/FOSRestBundle/blob/bd233aca63b0965171d60fe4c539afa10d45633e/Controller/Annotations/Route.php
14:53 <lsmith> Zerrvox: what breaks?
14:55 <Zerrvox> If you have a route annotation in a FOSRest Controller the method of the generated route ends up being null
14:55 <Zerrvox> which cannot be loaded
There was a problem hiding this comment.
It shouldn't be a BC break.
(array) null ends up being an empty [], which is is the default value for the methods property, and this code is in the constructor.
Although it might be a problem, tested it with both 1.6 and 1.7, and the methods part is definitely overwritten somewhere.
There was a problem hiding this comment.
