Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use Symfony's serializer even with JMS Serializer enabled #1072

Conversation

sroze
Copy link
Contributor

@sroze sroze commented Jun 22, 2015

Right now, if we're using the Symfony serializer and there's the JMS's one registered too for any reason, we can't due to a serializer normalizer not removed:

  [Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException]                                               
  The service "serializer" has a dependency on a non-existent service "fos_rest.serializer.exception_wrapper_normalizer".  

This PR fixes the problem.

@lsmith77 lsmith77 added this to the 1.7 milestone Jun 23, 2015
@lsmith77 lsmith77 added the Bug label Jun 23, 2015
@lsmith77
Copy link
Member

can you fix the tests?

@sroze sroze force-pushed the hotfix/use-symfony-serializer-even-with-jms branch 2 times, most recently from a99e50b to 8f8fcc6 Compare June 23, 2015 08:44
@sroze sroze force-pushed the hotfix/use-symfony-serializer-even-with-jms branch from 8f8fcc6 to db66463 Compare June 23, 2015 09:46
@sroze
Copy link
Contributor Author

sroze commented Jun 23, 2015

@lsmith77 tests are fixed, Travis just have network issues..

lsmith77 added a commit that referenced this pull request Jun 23, 2015
…n-with-jms

Allow to use Symfony's serializer even with JMS Serializer enabled
@lsmith77 lsmith77 merged commit ad2d2e7 into FriendsOfSymfony:master Jun 23, 2015
@sroze sroze deleted the hotfix/use-symfony-serializer-even-with-jms branch June 23, 2015 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants