Fixed LoaderInterface implementation for compatibility with symfony master #155
Conversation
|
is this backwards compatible? |
|
I don't think so because the typehint is not the same. |
|
Well it should be as |
|
and wit this change, I think you have the same error in Symfony 2.0 (but the opposit for servoces) |
|
ok .. guess i need to create a 2.0 branch then .. |
|
Cross-reference here: symfony/symfony#2785 You may wish to wait and see if that PR will ultimately go to 2.0 or master. But if it does go to master, it probably makes sense to have a 2.0 branch in this bundle w/o the interface change. |
|
Yes just to confirm this issue has broken with symfony master rendering our app unusable since there are no tags to fall back to. |
|
@jmikola if i see this properly its will be in 2.1 and not in 2.0, so its branch time in FOSRestBundle it seems: https://github.com/symfony/symfony/blob/2.0/src/Symfony/Component/Config/Loader/LoaderInterface.php#L51 |
Commits ------- ea2b0e5 Note LoaderResolverInterface type hinting in the 2.1 changelog Discussion ---------- Note LoaderResolverInterface type hinting in the 2.1 changelog Although #2785 was originally opened against 2.0, its merge to master seems to be intentional. This documents the BC break that some experienced (see: FriendsOfSymfony/FOSRestBundle#155).
No description provided.