Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "check for definitions before they might be removed" #1862

Closed
wants to merge 1 commit into from
Closed

Revert "check for definitions before they might be removed" #1862

wants to merge 1 commit into from

Conversation

XWB
Copy link
Member

@XWB XWB commented Feb 8, 2018 •
edited

Reverting #1805

Fixes #1856
Fixes #1855

@XWB XWB changed the title [WIP] Test Revert "check for definitions before they might be removed" Feb 8, 2018
@XWB
Copy link
Member Author

XWB commented Feb 8, 2018 •
edited

@xabbuh Reverting #1805 resolves the PHP 5.5 and Symfony 2 tests. Just the Symfony 4 test requires another fix.

@XWB XWB requested a review from xabbuh February 8, 2018 10:56
@xabbuh
Copy link
Member

xabbuh commented Feb 27, 2018

Thanks for investigating the failures @XWB. Closing in favour of #1873.

@xabbuh xabbuh closed this Feb 27, 2018
@XWB
Copy link
Member Author

XWB commented Feb 27, 2018

👍

@XWB XWB deleted the test branch February 27, 2018 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XWB @xabbuh