Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depreciate null validator on ParamFetcher constructor #1980

Merged

Conversation

l-vo
Copy link
Contributor

@l-vo l-vo commented Jan 17, 2019

Depreciate null validator on ParamFetcher constructor to remove runtime check (see below) at the next major version.

if (null === $this->validator) {

@l-vo l-vo force-pushed the depreciate_null_validator_param_fetcher branch 4 times, most recently from 0c94cd0 to 6105ef4 Compare January 17, 2019 21:06
@l-vo l-vo changed the title Depreciate null validator on ParamFetcher constructor WIP: Depreciate null validator on ParamFetcher constructor Jan 17, 2019
Request/ParamFetcher.php Outdated Show resolved Hide resolved
@l-vo l-vo force-pushed the depreciate_null_validator_param_fetcher branch from 6105ef4 to d834346 Compare January 18, 2019 05:35
@l-vo l-vo force-pushed the depreciate_null_validator_param_fetcher branch from d834346 to ea3cf1c Compare January 18, 2019 05:40
@l-vo l-vo changed the title WIP: Depreciate null validator on ParamFetcher constructor Depreciate null validator on ParamFetcher constructor Jan 18, 2019
@GuilhemN GuilhemN merged commit 52a6a47 into FriendsOfSymfony:master Jan 23, 2019
@GuilhemN
Copy link
Member

Thank you @l-vo :)

@l-vo l-vo deleted the depreciate_null_validator_param_fetcher branch February 13, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants