raise php/sf requirement, make symfony/templating optional dependency, fix tests #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuilhemN
approved these changes
Jul 31, 2019
extract tests using html templating rending into a legacy test and disable the templating in tests where it's not needed
…gBundle is enabled and the deprecated SF templating integration is used
|
I fixed all the
due to the templating by extracting tests using html templating rending into a legacy test and disable the templating in tests where it's not needed. Also fixed the default value for the exception_controller when twig is enabled but the templating sf integration is not. |
… test build pass with deprecations
Tobion
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix some depreactions as
Symfony\Bundle\FrameworkBundle\Templating\EngineInterfaceis deprecated but the extendedSymfony\Component\Templating\EngineInterfaceis not. And we do not need any methods of the FrameworkBundle EngineInteraface.