-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility with symfony/framework-bundle 5.4 #2330
Conversation
6dc146a
to
27dff47
Compare
27dff47
to
a29a20a
Compare
This might be a quick fix, but it's not a good fix IMO. There are 3 classes using the routing component in this bundle, but the component isn't declared in This would be a good time to make a better long-term fix. If the routing component should be a required dependency, it should be added to the |
I'm agree that it's not a definitive fix, but it will allow at short term to have a compatibility. I prefer to find another solution into this two months too. It seems not that difficult to remove some listeners/services at the condition where the |
I'd just put
|
I come to the same conclusion, what is your recommendation ? |
Closing in favor of #2340 |
This PR follow #2332
Tests are currently failling with
symfony/routing
v6.In order to be compatible with Symfony framework bundle in version 5.4 without delay, we have to add a conflict rule to avoid the installation of this version, the time to add/ensure a compatibility.