Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply rector rules for PHP 8.3 with typeDeclarations #2407

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from

Conversation

shakaran
Copy link

Applied rules:

@mbabker
Copy link
Contributor

mbabker commented Mar 13, 2024

I would suggest just closing this and submitting smaller pull requests if you want to pursue these types of changes. One pull request touching nearly 100 files in a single commit is asking too much of the folks who will ultimately be reviewing that work. Not to mention that some of these changes look to have potential B/C concerns or break compatibility in full with older PHP versions (some PHP 7 branches are still supported, yet I see a union typehint in one of the changed files, which is a PHP 8 feature).

@shakaran
Copy link
Author

ok, I will do smaller ones if makes more easy to merge it, but the idea here is make a B/C in a new release (maybe 4.0 or so).

But most important, the project should really support PHP <8.0 versions? Mostly considering that PHP 8.0 is EOL currently, it doesnt make sense keep supporting PHP 7 branches IHMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants