Add allowBlank option to queryparam

[mosch]

fixes issue #814

[mosch]

I'm not sure how the nullable option should work. i don't really get the difference. maybe this is redundant but the nullable option doesn't work?

[lsmith77]

@ClementGautier can you have a look here?

[lsmith77]

ping

[ClementGautier]

Sorry for the delay.

👍 because we already have a nullable option. (But, for me, as we already can do it using a Constraint we could instead drop nullable as well :P))

[mosch]

if (null === $value || '' === $value) {
  return;
}

Since the RegexValidator#L37 ignores everything that is null or an empty string, I think even if you're using a constraint with a regex that doesn't allow an empty string, the validation will pass.

So 👍 is a go for a merge?

[ClementGautier]

@mosch You can combine NotNull and Regex with a All constraint, I think it could work. But yes, as I said I'm ok with allowBlank option.

[mosch]

great, i think i should go and extend the test and then we can go for the merge. anything else missing?

[mosch]

i think it could should also be added in the testExceptionOnValidatesFailure() test, but the class is confusing to me a litte. any advice?

[ClementGautier]

@mosch I dont think its necessary. We only test strict cases on this test and, in this PR we only add "white cases" possibilities (which are covered by testValidatesConfiguredParam)

[lsmith77]

I guess this is ready to merge?

[lsmith77]

needs a rebase

[mosch]

did the rebase, everything should be fine now.

[mosch]

👍 thanks

[lsmith77]

@mosch can you have a look at #992 ?