Clean the use of flash messages

[stof]

Currently, the bundle does not use flash messages in a clean way, setting the translation key as message key and the CSS class as message. This works well as long as the flash message is rendered using the bundle's layout but breaks if the user replaces it.
The layout breaks also flash messages set by the user before going to a FOSUB page.

[lsmith77]

I don't understand the issue. There is no "standard" for setting flash messages, though maybe there should be.

[stof]

@lsmith77 putting the actual message as key of the flash message and the class as message seems wrong. As the flash message impacts the next request, we cannot be sure that they will be rendered by FOSUserBundle (or that they are set by FOSUserBundle for the first request reaching it)

[lsmith77]

But what else could we do? And how would anything else ensure a better outcome?

[stof]

dunno. This issue is about thinking about the issue to eventually find a better way than the current one.

[lsmith77]

well maybe we should define a standard and add it to the docs as a best practice then.

[stof]

@fabpot Do you have a best practice in mind about the way flash messages should be used ?

See also #132 for a previous discussion about them.

[bartclarkson]

Hello-

I came across a post that relates to this, I believe: https://coderwall.com/p/ybup5a

Why not pass your setFlash $value more like this:

$this->setFlash('notice', $this->container->get('translator')->trans('change_password.flash.success', array(), 'FOSUserBundle'));

In any event, thank you for the excellent bundle.

[bartclarkson]

Here's how I achieved this, probably as intended. I just extended all the controllers and overrode the setFlash method. Example here is the Registration Controller:

namespace Acme\UserBundle\Controller;

use FOS\UserBundle\Controller\RegistrationController as BaseRegistrationController;

class RegistrationController extends BaseRegistrationController
{
    protected function setFlash($action, $value)
    {
        $value = $this->container->get('translator')->trans($value, array(), 'FOSUserBundle');
        $this->container->get('session')->setFlash($action, $value);
    }

}
?>

Which allows the following in my top-level .twig template:

            {% for key, message in app.session.getFlashes() %}
            <div class="flash-message-wrapper">
                <div class="flash-message {{ key }}">
                    <span>{{ message }}</span>
                </div>
            </div>
            {% endfor %}

[stof]

@bartclarkson this issue has been resolved several months ago already.

[mdjaman]

@stof how you resolved this issue?

[mdjaman]

I don't see any changes?

[stof]

The 2.0 version (master branch) is translating messages in the listener setting them, and sets it properly (rather than using the message as key and the type as value)

[stof]

btw, the commit doing the change is linked (it was the commit closing the issue)