Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change : to :: for controller method (deprecated for 4.1) #2806

Closed
wants to merge 2 commits into from
Closed

Conversation

mazarini
Copy link

@mazarini mazarini commented Jun 6, 2018

Suppress deprecated messages and fix a php-cs-fixer message

@stof
Copy link
Member

stof commented Jun 6, 2018

that's dropping support for old older versions of Symfony. That's not something we can do yet.

@BackEndTea
Copy link

I have seen other bundles create a separate 4.1+ list of routes. That does mean that as long as versions below 4.1 are supported every update done to those files has to be done twice.

@sharif9876
Copy link

@stof do we have to override the routes ourselves then if using 4.1? The deprecation is currently not allowing phpunit to pass for my project

@pscheit
Copy link

pscheit commented Aug 17, 2018

there is an env var to disable deprecation warnings in phpunit

set SYMFONY_DEPRECATIONS_HELPER
to 0 in your phpunit xml file for example

@Tomsgu
Copy link

Tomsgu commented Aug 17, 2018

@stof Would solution of @BackEndTea (#2806 (comment)) be acceptable here or we should wait until 2.8 will be dropped?

@kubk
Copy link

kubk commented Sep 7, 2018

This warning makes my development log unreadable because of a lot of deprecation warnings.

@Tomsgu Setting SYMFONY_DEPRECATIONS_HELPER=weak is not acceptable because it only hides the deprecation instead of fixing it.

@kubk
Copy link

kubk commented Sep 9, 2018

@stof What do you think about creating separate xml files for Symfony 4.1+? Example: hwi/HWIOAuthBundle#1397

@Tomsgu
Copy link

Tomsgu commented Sep 10, 2018

@kubk I don’t know where do you find Symfony_deprecation_helper=weak.

I spoke about different routing files. One for 4.1+ and the other for old versions.

@kubk
Copy link

kubk commented Sep 10, 2018

@Tomsgu Sorry, you are right.

Also I agree with you about different routing files, for me it solves the problem.

@XWB
Copy link
Member

XWB commented Sep 19, 2018

Fixed in #2853

@XWB XWB closed this Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants