-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change : to :: for controller method (deprecated for 4.1) #2806
Conversation
that's dropping support for old older versions of Symfony. That's not something we can do yet. |
I have seen other bundles create a separate 4.1+ list of routes. That does mean that as long as versions below 4.1 are supported every update done to those files has to be done twice. |
@stof do we have to override the routes ourselves then if using 4.1? The deprecation is currently not allowing phpunit to pass for my project |
there is an env var to disable deprecation warnings in phpunit set SYMFONY_DEPRECATIONS_HELPER |
@stof Would solution of @BackEndTea (#2806 (comment)) be acceptable here or we should wait until 2.8 will be dropped? |
This warning makes my development log unreadable because of a lot of deprecation warnings. @Tomsgu Setting |
@stof What do you think about creating separate xml files for Symfony 4.1+? Example: hwi/HWIOAuthBundle#1397 |
@kubk I don’t know where do you find Symfony_deprecation_helper=weak. I spoke about different routing files. One for 4.1+ and the other for old versions. |
@Tomsgu Sorry, you are right. Also I agree with you about different routing files, for me it solves the problem. |
Fixed in #2853 |
Suppress deprecated messages and fix a php-cs-fixer message