Fix/php 7.2 deprecation warnings #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 30, 2017 01:52
(it's okay as minimal PHP version we support is 5.3)
|
|
j0k3r
reviewed
Jul 30, 2017
There was a problem hiding this comment.
Interesting.
You missed some create_function inside Doctrine plugin (like https://github.com/LExpress/symfony1/blob/master/lib/plugins/sfDoctrinePlugin/lib/task/sfDoctrineDropDbTask.class.php#L76)
|
Hm... It means that part is not covered with tests. Alright. I'll fix that as well. |
|
Yeah, the test suite doesn't cover 100% of the code. |
|
@j0k3r done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull replaces
create_functionusages to regular lambda functions (introduced in PHP 5.3) to improve PHP 7.2 compatibility.It will fix PHP nightly build compatibility at your Travis-CI output: