Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Remove database creation options #31

Merged
merged 1 commit into from
Apr 25, 2020
Merged

[TASK] Remove database creation options #31

merged 1 commit into from
Apr 25, 2020

Conversation

KoenWouters
Copy link
Contributor

Remove database creation options that cause failures with TYPO3 v10 SQL parser

Resolves: #30

@KoenWouters KoenWouters changed the title [TASK] Remove database creation options #30 [TASK] Remove database creation options Apr 15, 2020
@KoenWouters KoenWouters mentioned this pull request Apr 15, 2020
Merged
@liayn
Copy link
Member

liayn commented Apr 15, 2020

Did you find out why doctrine has issues with those (valid) SQL options? Are those not supported?

@haassie
Copy link
Member

haassie commented Apr 15, 2020

I guess it has something to do with default charset being a vendor specific option.

https://www.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/schema-representation.html#vendor-specific-options

@dmitryd dmitryd merged commit 75cf7e1 into FriendsOfTYPO3:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haassie haassie haassie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in table declaration of tx_openid_nonce_store
4 participants
@KoenWouters @liayn @haassie @dmitryd