[TASK] Switch to the core testing framework #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
force-pushed
the
task/core-testing-framework
branch
3 times, most recently
from
063b666
to
96e03a0
Compare
oliverklee
force-pushed
the
task/core-testing-framework
branch
3 times, most recently
from
3970f6b
to
01eeab2
Compare
|
I don't know current state, but https://github.com/sabbelasichon/typo3-rector/blob/main/src/Set/Extension/NimutTestingFrameworkSetList.php might be helpful. We used the set during a project update from V8 to V10 to also switch the framework, and it did the job. |
|
@DanielSiepmann Thanks! |
oliverklee
commented
Jan 26, 2022
lukaszuznanski
force-pushed
the
task/core-testing-framework
branch
from
53678ed
to
571ef3b
Compare
|
I got totally different errors locally in functional tests. |
|
This PR needs rebasing. |
lukaszuznanski
force-pushed
the
task/core-testing-framework
branch
3 times, most recently
from
e6ab9a8
to
01b414d
Compare
oliverklee
commented
Feb 15, 2022
| $connection = $this->getConnectionPool() | ||
| ->getConnectionForTable('tx_tea_domain_model_product_tea'); | ||
| $databaseRow = $connection->select(['*'], 'tx_tea_domain_model_product_tea', ['uid' => $model->getUid()]) | ||
| ->fetchAssociative(); |
There was a problem hiding this comment.
To be compatible with TYPO3 10LTS with lowest dependencies, we need to use the deprecated method here (maybe with a comment).
There was a problem hiding this comment.
These are the requirements in the composer.json of typo3/cms-core:
- V10:
"doctrine/dbal": "~2.10.0 || ~2.11.2 || ~2.13.1", - V11:
"doctrine/dbal": "^2.13.5", - main:
"doctrine/dbal": "^3.2",
oliverklee
force-pushed
the
task/core-testing-framework
branch
from
f868a25
to
dea0962
Compare
The TYPO3 core testing framework has more person-power for maintenance behind it compared to the nimut testing framework. So we should use that.
We need to have the paths of the TYPO3 testing framework now.
oliverklee
force-pushed
the
task/core-testing-framework
branch
from
dea0962
to
90a248c
Compare
`fetchAssociative()` is not available yet in doctrine/dbal 2.10 (which is thge lowest requirement for TYPO3 V10).
oliverklee
force-pushed
the
task/core-testing-framework
branch
from
90a248c
to
2e4f829
Compare
Thus, we can avoid using a function that was removed in newer versions of DBAL.
lukaszuznanski
approved these changes
Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TYPO3 core testing framework has more person-power for maintenance
behind it compared to the nimut testing framework. So we should use that.