Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid “Undefined index: namespace” error #26

Merged
merged 1 commit into from
Dec 20, 2017
Merged

Avoid “Undefined index: namespace” error #26

merged 1 commit into from
Dec 20, 2017

Conversation

alexislefebvre
Copy link
Contributor

@alexislefebvre alexislefebvre commented Dec 19, 2017

Avoid the following error when editing a menu:

Notice: Undefined index: namespace

@ghost ghost added the in progress label Dec 19, 2017
@lenybernard lenybernard self-requested a review December 19, 2017 18:09
Copy link
Contributor

@lenybernard lenybernard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the namespace option is mandatory if $businessEntityId !== null so you just setting it as null isn't clean for me but you can do this:

@alexislefebvre
Copy link
Contributor Author

@lenybernard thanks, I moved the check of $options['namespace'] since it's only used in the else block, so there's no need to check it earlier.

@lenybernard lenybernard merged commit dbe28f7 into FriendsOfVictoire:2.0 Dec 20, 2017
@ghost ghost removed the in progress label Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants