Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #24: Fix Javascript error with quantum #31

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Fixes #24: Fix Javascript error with quantum #31

merged 1 commit into from
Feb 20, 2018

Conversation

alexislefebvre
Copy link
Contributor

@alexislefebvre alexislefebvre commented Feb 20, 2018 •
edited
Loading

Fixes #24

There was a Javascript exception :

file:1 Uncaught ReferenceError: a is not defined
at HTMLAnchorElement.onclick

Because quotes were missing around the Javascript variable a:

<a href='#' onclick='addItemStaticForm('"", a)' …

@ghost ghost added the in progress label Feb 20, 2018
@alexislefebvre alexislefebvre changed the title Fix Javascript error with quantum Fixes #24: Fix Javascript error with quantum Feb 20, 2018
@lenybernard lenybernard merged commit f2e35ee into FriendsOfVictoire:2.0 Feb 20, 2018
@ghost ghost removed the in progress label Feb 20, 2018
@alexislefebvre alexislefebvre deleted the fix-js-error-with-quantum branch February 20, 2018 14:49
This was referenced Feb 20, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexislefebvre @lenybernard