Skip to content

Commit

Permalink
fix(filter): "Completed" and "Actived" filters have opposite effects
Browse files Browse the repository at this point in the history
see: #38
Thanks to "hashom" feedback on this bug.
  • Loading branch information
FriesI23 committed Jun 23, 2023
1 parent 22b2c1f commit c05f7e8
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions lib/view/for_habit_display/habit_display_main_menu.dart
Original file line number Diff line number Diff line change
Expand Up @@ -229,14 +229,14 @@ class _HabitsDisplayFilterListView extends StatelessWidget {
CheckboxListTile(
title: l10n != null
? Text(l10n.habitDisplay_statsMenu_inProgresTileText)
: const Text("Show Completed"),
: const Text("Show Actived"),
secondary: const Icon(HabitProgressIcons.progress_50percent),
enabled: habitsDisplayFilter.copyWith(allowCompleteHabits: false) !=
enabled: habitsDisplayFilter.copyWith(allowActivedHabits: false) !=
HabitsDisplayFilter.allFalse,
value: habitsDisplayFilter.allowCompleteHabits,
value: habitsDisplayFilter.allowActivedHabits,
onChanged: (value) {
var newFilter =
habitsDisplayFilter.copyWith(allowCompleteHabits: value);
habitsDisplayFilter.copyWith(allowActivedHabits: value);
if (newFilter != HabitsDisplayFilter.allFalse) {
onFetchNewDisplayFilter?.call(newFilter);
}
Expand All @@ -245,14 +245,14 @@ class _HabitsDisplayFilterListView extends StatelessWidget {
CheckboxListTile(
title: l10n != null
? Text(l10n.habitDisplay_statsMenu_completedTileText)
: const Text("Show Actived"),
: const Text("Show Completed"),
secondary: const Icon(HabitProgressIcons.progress_100percent),
enabled: habitsDisplayFilter.copyWith(allowActivedHabits: false) !=
enabled: habitsDisplayFilter.copyWith(allowCompleteHabits: false) !=
HabitsDisplayFilter.allFalse,
value: habitsDisplayFilter.allowActivedHabits,
value: habitsDisplayFilter.allowCompleteHabits,
onChanged: (value) {
var newFilter =
habitsDisplayFilter.copyWith(allowActivedHabits: value);
habitsDisplayFilter.copyWith(allowCompleteHabits: value);
if (newFilter != HabitsDisplayFilter.allFalse) {
onFetchNewDisplayFilter?.call(newFilter);
}
Expand Down

0 comments on commit c05f7e8

Please sign in to comment.