Fix mse for least squares PCE #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- stdout and stderr from solver run do not depend anymore on
relative paths.
- a warning will be throw when he solver has a relative path
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #128 +/- ##
=======================================
Coverage 99.06% 99.06%
=======================================
Files 23 23
Lines 852 852
=======================================
Hits 844 844
Misses 8 8
☔ View full report in Codecov by Sentry. |
|
Can you rebase you commit on |
FriesischScott
requested changes
Aug 29, 2023
FriesischScott
requested changes
Sep 3, 2023
|
|
||
| @test mean(pce) ≈ -1.5 rtol = 1e-10 | ||
| @test var(pce) ≈ 0.5 rtol = 1e-10 | ||
| @test isapprox(mse, 3e-30, atol=1e-10) |
There was a problem hiding this comment.
This is not an adequate test for the mse. You need to get the y values from the returned samples and compare them to evaluate!(pce, copy_of_samples) with copy_of_samples = samples[:, Not(:y)].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The evaluation of the mse of PCE with "least squared" method was performed without the division by the number of samples.