Skip to content

Commit

Permalink
fix: array deserialization
Browse files Browse the repository at this point in the history
  • Loading branch information
calebmpeterson committed Feb 4, 2024
1 parent 74a43a7 commit c9fbec6
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
2 changes: 1 addition & 1 deletion packages/js-client/src/core/remote-storage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export class RemoteStorage {
}
const data = await response.text()
// Check if valid JSON
if (!data.startsWith('{')) {
if (!data.startsWith('{') && !data.startsWith('[')) {
if (data === 'true') {
return true as unknown as T
}
Expand Down
7 changes: 7 additions & 0 deletions packages/js-client/test/remote-storage.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,13 @@ describe('global storage', () => {
expect(value).toEqual('value')
})

it('should be able to set and get an array', async () => {
const remoteStorage = new RemoteStorage(getConfig())
await remoteStorage.setItem('key', ['foo', 'bar'])
const value = await remoteStorage.getItem<string[]>('key')
expect(value).toEqual(['foo', 'bar'])
})

it('should be able to set and get an object', async () => {
const remoteStorage = new RemoteStorage(getConfig())
await remoteStorage.setItem('key', { foo: 'bar' })
Expand Down

0 comments on commit c9fbec6

Please sign in to comment.