Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required changes for Windows code execution and NSFW UI and config updates. #28

Merged
merged 10 commits into from
Jul 18, 2023

Conversation

RaineAllDay
Copy link
Collaborator

Addresses #23 To allow toggling of the SFWListsDisabled config option within the UI. Added 2 locations. One location is located next to the notification icon. Will be a grey "ban" icon when SFWListsDisabled = false (aka hiding "nsfw" stuff). Will be a red "ban" icon when SFWListsDisabled = true. Added a new config variable, that as I type this I realize is redundant, will remove in next update.

Also updated some of the Electron app building scripts to work with windows.

rainwakr and others added 6 commits July 6, 2023 00:12
Added UI Elements for SFWListDisabled
Created alwaysShowNSFWLists
Updated Board ListItem to change on alwaysshownsfwlists
Updated feapi, clapi protos.
Updated configstore
Copy link
Collaborator Author

@RaineAllDay RaineAllDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated get-version-from-git.js

@RaineAllDay
Copy link
Collaborator Author

actually that didn't help either. let me go back to testing.

@RaineAllDay
Copy link
Collaborator Author

it's failing for linux builds it looks like... so I'm going to spin up a VM and get it setup real quick.

@Frigyes06
Copy link
Owner

Builds and runs. Can't see new UI Element though...

Copy link
Owner

@Frigyes06 Frigyes06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Frigyes06 Frigyes06 merged commit 3b8d909 into Frigyes06:master Jul 18, 2023
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants