-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Motor resonance filter #131
base: develop
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request introduces a motor resonance filter feature to Shake&Tune, allowing users to apply and remove motor resonance filters. It also includes refactoring for better configuration initialization and command registration, and updates the documentation to reflect the new configuration options. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Frix-x - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 9 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Frix-x - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 8 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 3 issues found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
WIP
Summary by Sourcery
This pull request introduces a motor resonance filter feature to Shake&Tune, allowing users to apply and remove motor resonance filters for X and Y axes. It also includes refactoring of the ShakeTune class for better configuration and command handling, enhancements to motor frequency profile computation, and updates to the documentation to reflect the new configuration options.