Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IS_vibrations_measurements.cfg #14

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Conversation

Fragmon
Copy link
Contributor

@Fragmon Fragmon commented Nov 26, 2023

Include the acceleration value explicitly. Otherwise, it defaults to the max_acceleration value from the printer configuration, which in most cases does not match the printing acceleration. If people use the slicer limiter and set a high max_acceleration in the printer.cfg, it can potentially cause damage.

@Frix-x
Copy link
Owner

Frix-x commented Nov 26, 2023

Oh you cut the grass under my foot haha
I wanted to work on something like that for some time to avoid running at max accel for the vib measurement since this usually give wrong results that are not really interesting. I'll see how to base my work on this PR :)

@Frix-x Frix-x changed the base branch from main to accel-patch November 27, 2023 14:50
@Frix-x Frix-x self-assigned this Nov 27, 2023
@Frix-x Frix-x merged commit 0f7fa66 into Frix-x:accel-patch Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants