v.2.5.0 #39
Merged
v.2.5.0 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motor resonance characterization
Workflow rework
This was
linked to
issues
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motor shaft resonance analysis added to the vibration measurements. While currently, it doesn't offer immediate practical applications, it enables the measurement of the motor shaft's main resonance in your machine. It's important to note that this data represents a physical parameter of the motor and serves primarily as informational for now. However, exciting future plans are in the works on this topic – stay tuned!
Extensive tracing and analysis of the Python code were done in order to optimize it and lower the memory requirements. This leads to improvements in memory usage and speed. For example, on my testing rig, I was able to lower the RAM requirement by 75% and speed up the belt graph generation by 10x. Moreover, the updated code is confirmed to be functional on devices with limited resources, like the PiZero2W and Rpi2, using a total of around 100MB of RAM.
Alongside the code optimizations, a major refactoring of the code was done in order to avoid code duplication and keep it easier to maintain and understand. I hope this will make it easier for the community to create PRs on Shake&Tune :)
Shake&Tune entrypoint script parameters handling was improved in order to be more flexible and robust. This update allows users to adjust settings like the number of results to retain in the folder, and whether to keep CSV files alongside the PNG result graphs directly from the Klipper macros! These improvements aim to make Shake&Tune more user-friendly and adaptable to various needs.
The last point also allowed to also use the accelerometer chip name as a parameter as well. This means that Shake&Tune now supports a wider range of accelerometer chips beyond the ADXL345, including the LIS2DW that start to become more common, but also all the others compatible accelerometer with Klipper.
Added a small watermark in the top right corner to indicate the Shake&Tune version used. This allows easier debugging and understanding of the data for every graph shared on the internet.
Improved some parts of the documentation and especially added some bits about the new motor frequency profile of the vibration measurement graphs.