Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expander_templates #567

Merged
merged 8 commits into from
Jun 18, 2024
Merged

Expander_templates #567

merged 8 commits into from
Jun 18, 2024

Conversation

Benoitone
Copy link
Collaborator

Add Klipper Expander and Arduino nano templates in new expand mcu section.
Add also section in install script

@Benoitone Benoitone mentioned this pull request Mar 22, 2024
@Benoitone Benoitone added the user template This issue or PR refer to one of the user template file label Mar 25, 2024
@Foose83
Copy link

Foose83 commented Apr 1, 2024

Bonjour, ça ma l'air vraiment très bien.
Merci beaucoup.

Copy link

@Foose83 Foose83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tout a l'ait très bien.

@Surion79
Copy link
Collaborator

Surion79 commented Apr 6, 2024

would it be possible to name the folder "expander" instead of "expand"? currently Klippain uses noms for templates, not verbs

Copy link
Collaborator Author

@Benoitone Benoitone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be possible to name the folder "expander" instead of "expand"? currently Klippain uses noms for templates, not verbs

done

Copy link
Collaborator

@Surion79 Surion79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me. can't test it though. using multiple expander boards require additional work when it is greater than 1?

@Surion79 Surion79 linked an issue Apr 18, 2024 that may be closed by this pull request
@Surion79 Surion79 changed the title Expand_templates Expander_templates Apr 18, 2024
Copy link

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

@Foose83
Copy link

Foose83 commented Jun 4, 2024

Bonjour, je voudrez le tester mais je n'y arrive pas, je ne sais pas comment faire.
J'ai essayé mais j'ai des erreurs, je pense que je n'ai pas bien procédé.

Copy link
Owner

@Frix-x Frix-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll merge :)

@Frix-x Frix-x merged commit 6079072 into develop Jun 18, 2024
@Frix-x Frix-x deleted the expand_templates branch June 18, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user template This issue or PR refer to one of the user template file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Klipper expander
4 participants