Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong git branch used for 5.9RC #58

Closed
Sjoeborg opened this issue Sep 3, 2020 · 6 comments · Fixed by #62
Closed

Wrong git branch used for 5.9RC #58

Sjoeborg opened this issue Sep 3, 2020 · 6 comments · Fixed by #62
Labels
bug Something isn't working

Comments

@Sjoeborg
Copy link

Sjoeborg commented Sep 3, 2020

The RC for 5.9 lives in branch "master" https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
This causes an error when the script tries to clone the branch linux-5.9.y
The install script should clone the master branch if the user wants to compile the RC

Line 114 in the install script reads
git clone --branch linux-$_basekernel.y --single-branch --depth=1 https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git linux-${_basekernel}

could be

git clone --branch master --single-branch --depth=1 https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git linux-${_basekernel}

@AdelKS
Copy link
Collaborator

AdelKS commented Sep 3, 2020

Yes we are aware of that, the script is there when 5.9 gets released :)

To work, it needs some more work than just changing the branch, if you are willing to make the changes and test them out on Ubuntu, Fedora and Suse you are welcome!

@Tk-Glitch Tk-Glitch added the bug Something isn't working label Sep 4, 2020
@AdelKS
Copy link
Collaborator

AdelKS commented Sep 4, 2020

@Tk-Glitch Why did you add the "Bug" label, is it because I don't like to see "Bug" as a label and thus implement a script that handles RC kernels ? xD

@Sjoeborg
Copy link
Author

Sjoeborg commented Sep 4, 2020 via email

@AdelKS
Copy link
Collaborator

AdelKS commented Sep 4, 2020

Hello @Sjoeborg,

The label hasn't been added by you, but by @Tk-Glitch :D
For your issue, the other kernels works with install.sh. I may implement the script that handles rc kernels in the future :P

@Tk-Glitch
Copy link
Member

@AdelKS Let's say it was more for me to see it better. It's technically a broken implementation, but since it's there in 5.9rc.. 🐸 Don't get stressed out about it. If I'm happy with the centralization of linux-tkg it'll become necessary anyway so the fix for RCs might land at the same time. Tarballs aren't all that bad 😛

@AdelKS
Copy link
Collaborator

AdelKS commented Sep 5, 2020

You are working on centralization ? :D

You know what, I will implement the RC script. It will be the same for all RC versions.

AdelKS added a commit to Kodehawa/linux-tkg that referenced this issue Sep 12, 2020
Tk-Glitch pushed a commit that referenced this issue Sep 12, 2020
* Add initial -rc support to install.sh script.

* Fix wording.

* Creating a RPM doesn't seem to create a package with the -rc name on it, so add it manually.

* Fix issues with patch applying when the source folder already exists.

* rpm-src is webscale.

* Turns out you can't use dashes in rpm-src, good to know.

* Final fixes.

* Re-use the .tar.gz file we downloaded if re-building.

* Make tar less verbose.

* oops

* linux59-rc: install.sh: Fix DEB naming in install process

* linux59-rc: install.sh: Use git instead of tar packages

Fix #58

Co-authored-by: Adel KARA SLIMANE <adel.ks@zegrapher.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants