Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added winex11: Moved child window buffer copy to vkQueuePresentKHR to… #792

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

pac85
Copy link
Contributor

@pac85 pac85 commented Jun 28, 2022

Normally the copy is done in vkAcquireNextImageKHR ( relevant line ) but it would make more sense to do it during a call to vkQueuePresentKHR. This causes a bug in SeriousEditor (and potentially other programs) where the ui is displayed with a 1 event delay making it unusable (as well as showing uninitialized buffers whenever they are reinitialized).

Fixes #790

@Tk-Glitch
Copy link
Member

Thanks again @pac85 ! Let's merge :)

@Tk-Glitch Tk-Glitch merged commit 7ea035c into Frogging-Family:master Jun 29, 2022
@pac85
Copy link
Contributor Author

pac85 commented Jun 29, 2022

Thank you again for giving me the opportunity to contribute!

Tk-Glitch added a commit that referenced this pull request Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulkan child window buffer copy happens at the wrong point
2 participants