Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic when passing a zero-sized output buffer. #23

Closed
golddranks opened this issue Apr 12, 2018 · 1 comment
Closed

Panic when passing a zero-sized output buffer. #23

golddranks opened this issue Apr 12, 2018 · 1 comment

Comments

@golddranks
Copy link
Contributor

miniz_oxide::inflate::core::decompress will panic if a output buffer of size 0 is passed in. The panic is due to an overflow in core.rs, on line 1020: out_cur.get_ref().len() - 1.

It says that "This function shouldn't panic pending any bugs." in the documentation so I presume this is a bug.

@oyvindln
Copy link
Collaborator

That is indeed a bug, thanks for noticing.

Frommi pushed a commit that referenced this issue Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants