Skip to content

Commit

Permalink
Fixed a Shipping bug in Sales Order Report
Browse files Browse the repository at this point in the history
  • Loading branch information
@joe-hunt
joe-hunt committed Jan 20, 2018
1 parent 06bb886 commit 009fd65
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion reporting/rep110.php
View file
Expand Up @@ -158,7 +158,7 @@ function print_deliveries()
$rep->NewLine();
if ($myrow['ov_freight'] != 0.0)
{
$DisplayFreight = number_format2($sign*$myrow["ov_freight"],$dec);
$DisplayFreight = number_format2($myrow["ov_freight"],$dec);
$rep->TextCol(3, 6, _("Shipping"), -2);
$rep->TextCol(6, 7, $DisplayFreight, -2);
$rep->NewLine();
Expand Down

1 comment on commit 009fd65

@apmuthu
Copy link
Contributor

@apmuthu apmuthu commented on 009fd65 Jan 20, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In rep102.php, $sign is computed and then used in the sql so it is okay.

In rep107.php, $sign is assigned 1 and used and hence it can be fully eliminated unless there are some CAST issues.

In rep113.php, $sign is assigned -1 and used and may be removed likewise and the sign made inline.

In rep109.php, rep111.php and rep209.php just as in rep110.php here, $sign is not assigned anywhere in the script and hence can be removed as done herein.

Please sign in to comment.