Additional ci setup #16
Conversation
Have not added tests yet; refactoring is needed
Including commenting out some apparently unneeded dev dependencies
| } | ||
| }, | ||
| "lint-staged": { | ||
| "*.js": ["eslint"] |
There was a problem hiding this comment.
Could add --fix to auto fix errors on commit. Does lint-staged need to include jsx files too?
There was a problem hiding this comment.
Thanks! The reason I don't the linter running over jsx files is that I don't have any jsx files. I read that Facebook doesn't recommend using the jsx extension anymore (facebook/create-react-app#87) so I've just been using js for everything. On the other hand, AirBnB recommends the jsx extension, so it could go either way. http://airbnb.io/javascript/react/
Similarly, I don't run --fix because I've got a few areas where eslint throws a warning (but not an error) that I don't want to change that could be changed by --fix. Thanks very much for the thoughtful comments :)
Add additional CI, including Husky.
This PR also adds CI-related badges to the README