New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the updating phase in the react component lifecycle #38

Merged

codylindley merged 1 commit into FrontendMasters:master from glrodasz:hotfix-correct-update-lifecycle

Mar 22, 2017

Contributor

glrodasz commented Mar 22, 2017

There is an issue on section 6.7 where the update lifecycle is wrong, it says:

Updating Phase follows this order:
componentWillReceiveProps()
shouldComponentUpdate()
render()
Children Life cycle methods
componentWillUpdate()

But it should be:

Updating Phase follows this order:
componentWillReceiveProps()
shouldComponentUpdate()
componentWillUpdate()
render()
Children Life cycle methods
componentDidUpdate()


          Fixing the updating phase in the react component lifecycle

b253d5c

glrodasz mentioned this pull request

componentWillUpdate() comes before render() #26

Open

codylindley merged commit 0908b19 into FrontendMasters:master

Collaborator

codylindley commented Mar 22, 2017

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment