Domainimport does not use Default Redirect Code

[Af0x]

Hello,
if you import Domains via csv and enter an URL as Docroot it does not use the Redirect Code set under the webserver-settings. It always uses 301.
Regards,
Af0x

[d00p]

It's not the import but the cronjob ;) This should also be the case when you add the domain as admin. Could you try again with the attached patch?

fix-default-domain-redirectcode.diff.txt

[Af0x]

I already changed all Codes manually :/

[Af0x]

I try to change your diff manually and need to know what things like this mean:

@@ -964,7 +964,7 @@ class apache extends HttpConfigBase

[d00p]

It's a patch file....https://git-scm.com/docs/git-apply

[Af0x]

now I was able to run the job but it failed with Error:

Syntax error on line 14 of /etc/
apache2/sites-enabled/35_froxlor_normal_vhost_domain.tld.conf
RewriteRule: bad flag delimiters

Line 14 says something like this:

RewriteRule ^/(.*) https://%{HTTP_HOST}/$1 [R=307 ();L,NE]

I set 307 as default.

[Af0x]

I also want to suggest: maybe it makes sense to set a separate RedirectCode for http to https?
Because in my opinion 301 would be fine in this case but not always for other cases like Redirecting to an other domain temporarily.

[d00p]

Ah, damn function adds the code-description too, try this:
https://gist.github.com/d00p/2b5bb1cfafd3b1e8b6ad4b7d6c95d9d0

[Af0x]

now it works from my perspective, thank you :)