Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Honor template depenencies #896

Closed
dtugend opened this issue Nov 4, 2020 · 1 comment
Closed

[Feature request] Honor template depenencies #896

dtugend opened this issue Nov 4, 2020 · 1 comment
Assignees
Milestone

Comments

@dtugend
Copy link

dtugend commented Nov 4, 2020

This will either be inefficient or not easy, so I can understand if it has to be rejected.

Let me give an example:
E.g. by default {CUSTOMER_EMAIL} is used in PHP config template for sendmail options.
Currently changing the customer email of in the customer settings will not cause the files to be updated accordingly (at least for PHP-FPM).

Not sure if it's still solvable without a dependency tree / graph.
(Everything that has variables that can change and has the output cached has that problem.)

@d00p
Copy link
Member

d00p commented Nov 4, 2020

Yes, this is correct. Changing user properties does not trigger a rebuild of config-files. It should be no problem to add a trigger there but I'd rather take a deeper look on the dependencies (so we do not trigger rebuild more than necessary) so i postpone this to 0.10.23 as 0.10.22 is due on friday :)

@d00p d00p added this to the 0.10.23 milestone Nov 4, 2020
@d00p d00p self-assigned this Nov 4, 2020
@d00p d00p closed this as completed in 79e670f Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants