Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding configuration file for OpenSUSE Leap 42.1 to lib/configfiles #366

Closed
wants to merge 1 commit into from

Conversation

asemen
Copy link

@asemen asemen commented Jun 28, 2016

As the configuration files for openSUSE were dropped in past,
I would like to asks you to add this Configuration file or openSUSE Leap 42.1 named leap_42.1.xml to froxlor upstream project.

</commands>
</general>
<!-- HTTP Apache -->
<daemon name="apache" version="2.4" title="Apache 2.4">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing default=true

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing acme.conf for lets encrypt (global alias) for apache

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok were to be added?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I do not understadn waht to do?
Please help.
Were should be default=true added?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<daemon name="apache" version="2.4" title="Apache 2.4" default="true">

@d00p
Copy link
Member

d00p commented Jun 28, 2016

and imho as we do not support multiple versions of opensuse, I'd suggest renaming the file to opensuse.xml

<command><![CDATA[service apache2 restart]]></command>
</daemon>
<!-- HTTP Lighttpd -->
<daemon name="lighttpd" title="LigHTTPd">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing acme.conf for lets encrypt (global alias) for lighttpd

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to change it to opensuse.xml

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asemen
Copy link
Author

asemen commented Jun 29, 2016

Did the wanted change adds related to comments

@d00p
Copy link
Member

d00p commented Oct 13, 2019

Leap is now 2 years old, recommend either doing this for current 15.1 (2019-10-03) or close this as I am not very familiar with openSuse and cannot maintain that

@asemen asemen closed this Oct 14, 2019
@asemen
Copy link
Author

asemen commented Oct 14, 2019

Lets close this. It tooks to long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants