Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for instagib #318

Closed
wants to merge 6 commits into from
Closed

Conversation

IyeOnline
Copy link
Contributor

Removed the "gear select" buttons from both the menu and the team select window via hacky "catchers" which will take the 1st mousemovement and remove the buttons and themselfs. Works as long as you stay on the map.

Also added more info about the instagib modifier to the team select window. Originally intended to add it below the gametype info, but couldnt as Bomb mode is too long.

A demo pk3 can be downloaded here

Preview:
shot0003

added a catcher for instagib mode, which will hide the gear select button as soon as you move your mouse.

sadly there was no other way as the button already gets hidden via CvarTest "g_gamemode", and that cant be used twice.
Removed the gear select tab when g_instagib 1 using a catcher.

Also added info about instagib.
@Barbatos Barbatos added this to the 4.3.1 milestone Sep 21, 2016
@IyeOnline
Copy link
Contributor Author

IyeOnline commented Sep 21, 2016

btw. i have a version with an ugly looking badly alphaed skull as well: click me (also more previews there)

@Barbatos Barbatos modified the milestones: 4.3.1, 4.3.2 Oct 4, 2016
@BidyBiddle
Copy link
Contributor

The Team Select button should not be removed for InstaGib. You can play a 3v3 CTF InstaGib game if you'd like, with teams.

@IyeOnline
Copy link
Contributor Author

That's actually not an issue. They arent shown because i tested in FFA, so they got hidden. :)

@BidyBiddle
Copy link
Contributor

That I know, I actually missread your first line and thought you had actually removed the "Team Select" part, and not removed the "gear select" from the "*Team Select" :D

@IyeOnline
Copy link
Contributor Author

:) quake menu magic :)

@Barbatos Barbatos self-assigned this Dec 18, 2016
Copy link
Member

@Barbatos Barbatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the info about Instagib being displayed when hovering the box.
However, the gear select button should not be hidden in instagib as you are still free to select items in this mode (medkit, helmet, kevlar, nvg...).
Could you please revert that part?

@IyeOnline
Copy link
Contributor Author

Oh. right. i didn’t consider NVGs. They are literally the only item you can "use" in instagib, everything else is pretty much pointless. Probably other items should be disabled in instagib, so players don’t run around with a kevlar when its not of any value anyways.

I will check if i can just hide all the other parts of the menu and let players select if they want NVGs or not.

@IyeOnline
Copy link
Contributor Author

IyeOnline commented Dec 21, 2016

actually, while i CAN do this, it doesnt make much sense. There only is value in two items in instagib, that being the medkit, in case someone lemmings, and the tac googles.

Now, obviously everyone would want a medkit, since you can select three items anyways. Tacs are literally the only choice. If it would be possible, could you set it up so that every player gets a medkit? Would make it a little easier for me.

Currently im aiming at only allowing to select item1, and item 2 would always be the medkit.

Additionally, i noticed that in no team modes, one gets redirected to the gear selection directly, which requires another catcher over the gear selection. (maybe you can change this as well?)

(and yes, i clicked that close button by accident...)

@IyeOnline IyeOnline closed this Dec 21, 2016
@IyeOnline IyeOnline reopened this Dec 21, 2016
@Barbatos
Copy link
Member

You're right! Silly me. Giving a medkit to everyone and not showing the gear selection menu would do it for me. I also noticed that in certain gametypes the gear selection menu is shown no matter what. I'll have a look into it.

@IyeOnline
Copy link
Contributor Author

Currently my setup (not uploaded yet) assumes that every player gets a medkit as item No.2 .
Item 1 can still be selected via the menu. (because maybe players don’t want to have tacs)

Ive also added a "catcher" to the normal gear selection menu that will automatically redirect you to the instagib selection menu, if g_instagib 1. This solves the case of automatically spawning in the gear selection menu in no teammodes, as well as redirecting players that use the bind to open the gear selection meniu

Depending on how hard a qvm implementation would be to achieve this, i could remove it again.

the weapon/gear button now links to the instagib wepon menu if g_instagib 1
Added a "simplified" menu for instagib item selection.

item #2 still needs to be set via some magical QVM script/whatever.
the weapon/gear tab now opens the instagib item selection menu.
Added the new instagib item selection menu to the list of loaded ingame menus.
@IyeOnline
Copy link
Contributor Author

IyeOnline commented Dec 22, 2016

So yeah. I changed the setup such that we now have a new Instagib selection menu, which only allows for the selection of item no1.

There is 3 points left to do, preferably by some QVM script

  • setup a system that automatically gives all players a medkit as item no2
  • change the automatic redirection to the gear selection menu in FFA modes
  • change the ui_selectgear behaviour in instagib

As an alternative for the last 2 points, i can make the gear selection menu redirect itself to the instagib version, but the normal one would still be shown initially.

(btw: i updated the link in the OP for the download)

@Barbatos
Copy link
Member

Mmh.. adding a complete new gear menu just for some instagib tweaks seems overkill to me. :/
I think I'll stick to the first version + give a medkit to everyone + hide the gear selection menu.

@IyeOnline
Copy link
Contributor Author

Well, your point about items made me think about it, and i figured, tacs are still a thing. And they actually still do something in Instagib.

So i went "all out" and added a menu. Don't really care if you use it, but if you don't, consider disabling tacs in Instagib

Barbatos added a commit that referenced this pull request Feb 1, 2017
…STAGIB" box in the team selection menu.

See #318

- Cleanup of old/useless comments
@Barbatos
Copy link
Member

Barbatos commented Feb 1, 2017

Thank you very much Iye for your contribution, please see #385 for the final patch!

Here is what was done for Instagib in 4.3.2:

  • prevent bots from switching to knife
  • when active, display a gamemode explanation text + an "INSTAGIB" box in the team selection menu
  • prevent the gear selection menu from being opened if playing Instagib
  • everyone has a medkit as their sole item
  • if active, show " - INSTAGIB" next to the game mode name on the map load screen, to signal that instagib is on

@Barbatos Barbatos closed this Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants